search

sstsimulator / sst-macro

SST Macro Element Library
http://sst-simulator.org/
Other
34 stars 41 forks source link

Macro std::thread replacement fails with newer libc++ #644

Closed calewis closed 2 years ago

calewis commented 2 years ago

This was first brought to our attention with newer Xcode builds, but it is all newer libc++s. The issue is that libc++ now forward declares std::thread in more places causing conflict.

No timeline on the fix right now.

jpkenny commented 2 years ago

We were doing badly non-standard-compliant things here to make std::thread replacement work and it came back to bite us. I don't see a workaround except perhaps using the source-to-source tool. I'm just going to disable the feature and the two tests that depend on it for now. It's really just a "nice to have" at this point, since none of the existing skeletons depend on this feature.

jpkenny commented 2 years ago

Addressed by PR #673