search

sstur / react-rte

Pure React rich text WYSIWYG editor based on draft-js.
https://react-rte.org
ISC License
2.86k stars 430 forks source link

Fix Link and Image popover button not working in React 17 #399

Closed iPilotte closed 3 years ago

iPilotte commented 3 years ago

React 17 has made changes to event delegation, so it'll also call _onDocumentClick when trying to toggle popover (it make popover toggle twice: off -> on -> off) image

sanjevirau commented 3 years ago

Please merge this as I'm facing the same problem with React 17! Thanks a lot @iPilotte @sstur

sh4nd00 commented 3 years ago

Im having the same issue. Please merge @iPilotte @sstur

inkinkz commented 3 years ago

I'm having this issue too. Please merge this. Thanks @iPilotte

nejsimon commented 3 years ago

This solves the problem indeed. Please consider merging this PR and making a new release @sstur ! Thanks.

inatnun commented 3 years ago

Please merge this PR, we really need it. @sstur

williamhoos commented 3 years ago

@iPilotte (or anyone else) interested in some work to help build a couple bits of functionality?

AlexeyBee commented 3 years ago

Please merge this PR, @sstur

aattsai commented 3 years ago

Please merge this PR

athanph commented 3 years ago

Getting this problem too. Please merge. Thank you.

secrecysiu commented 3 years ago

Please merge this PR, we really need it too and please also fix the checkOptions warning

sstur commented 3 years ago

Hey @iPilotte, thanks for the fix!

Blubagoo commented 3 years ago

This was merged but i dont think a new version was released on npm. Can you please release a new version for us?

RobRendell commented 2 years ago

It seems that someone has released a forked version with the fix on NPM: https://www.npmjs.com/package/react-rte-17

Unfortunately there is no @types/react-rte-17 Typescript definition package, but Typescript users can create their own .d.ts module definition which imports the types from @types/react-rte and exports them for module react-rte-17.

kieranbenton commented 2 years ago

Thanks @RobRendell for the info! @sstur is it worth reaching out to @kjanoudi (who made the NPM release) and ask them to help with the main project since they're obviously able?

sstur commented 2 years ago

This was merged but i dont think a new version was released on npm. Can you please release a new version for us?

This has gone out with v0.16.4.