search

sstur / react-rte

Pure React rich text WYSIWYG editor based on draft-js.
https://react-rte.org
ISC License
2.86k stars 431 forks source link

Support for React 17 #415

Closed ale917k closed 2 years ago

ale917k commented 2 years ago

Since upgrading to React 17, the package manager flags about a difference in peer dependency version for react: react-rte@0.16.3" has incorrect peer dependency "react@0.14.x || 15.x.x || 16.x.x". react-rte@0.16.3" has incorrect peer dependency "react-dom@0.14.x || 15.x.x || 16.x.x".

Can the dependency be updated accordingly? No new feature changes have been introduced, thus no breaking changes can be introduced with the upgrade

erikt9 commented 2 years ago

There's still #409 with React 17, but once that is addressed I think the package should be good.

sstur commented 2 years ago

Done. This was released with v0.16.4

joeyzhousherwin commented 2 years ago

Hi @sstur , I'm trying to install react-rte, but my project is already at react 17.0.2.

Is there anyway i can install it? i tried npm i react-rte, but it wouldn't let me

erikt9 commented 2 years ago

I think you'll need to do it with npm install --legacy-peer-deps react-rte as the package.json hasn't been updated to say React 17 is supported.

the-serious-programmer commented 2 years ago

@sstur this issue still exists. 

  "peerDependencies": {
    "react": "0.14.x || 15.x.x || 16.x.x",
    "react-dom": "0.14.x || 15.x.x || 16.x.x"
  },

|| 17.x.x needs to be added to this for the above issue to be truly resolved

sstur commented 2 years ago

Oops, it looks like I needed to cut a new release to npm. That is now done. Thanks!