Closed ssu-readinglists closed 11 years ago
Just to note that in my latest code all passwords are configured via Moodle settings - if we can get a version of the code up I can update this
Owen - what do you think about moving other localisations from the list Lauren sent you into a config file? Apparently not essential as no usernames/passwords, just local settings, but if this is not too time consuming, might be worth considering as well?
I definitely think we should move the remaining localisation out of the main code, but think that where the localisation is a language file then this is an appropriate way of dealing with the localisations. The latest code removes two of the localisations from the code - one becomes a setting and one is now just automatically picked up from general Moodle settings.
A summary of where we are with the settings:
Files with local information | Notes |
~/moodle/filter/refshares/lang/en/filter_refshares.php; lines 6, 18 | Lang file |
~/moodle/mod/refworks/lang/en/refworks.php; lines 10, 59, 60 | Lang file |
~/moodle/mod/readinglist/lang/en/readinglist.php; line 54 | Lang file |
~/moodle/local/references/apibib/apibib_lib.php; lines 43, 114 | Moved to settings in most recent code |
~/moodle/local/references/linking.php; line 235 | Local data setting derived directly from Moodle root url in most recent code |
~/moodle/local/references/simpletest/test_references.php; line 202 | Code testing framework - not appropriate for setting |
~/moodle/mod/refworks/createbib.php; line 171 | Needs to be moved to a lang file |
~/moodle/mod/refworks/collab/collab_create.php; line 96 | Needs to be moved to a setting |
~/moodle/mod/refworks/refworks_folder_api.php; line 173 | Needs to be moved to a setting |
~/moodle/local/references/getdata.php; lines 500, 501 | Need a settings based mechanism for mapping library abbreviations to full library names |
In the next code update I can deal with these outstanding localisations
To discuss at next meeting 01/05/13
Agreed technical meeting that this plan is fine - please go ahead and deal with outstanding localisations as you have suggested above and via email.
Problem with shared accounts on the dev server only - localisation issue: [LIVE IS FINE]
Owen: I think the problem might be the localised setting on this line of code: ~/moodle/mod/refworks/collab/collab_create.php; line 96 This is already on the list to move to a setting in the next code release. If I'm right then to get this working for now you'll need to edit this file from $result = rwapi::create_account(htmlspecialchars($login),$pass,'Shared team account','[local data - shared team account email]',5);
[[See email for shared team account email string.....]]
To get it working again.
DP/RE to check then HY to test
Code now added for two of the settings. Remaining setting and issue of the error on dev split out into separate issues - will close this one and use two new issues to track those. New issues are #60 and #61
On live, added in temp name and account on 25/07/13 to fix refreshing issue (also debugging causes refresh problem). Should not need to do on live again now as is set after upgrade.
To remove emails/passwords etc within the code and for ease of loading
LS to email Owen details of readme file she is creating so we can take forward