search

ssu-readinglists / readinglists

GNU General Public License v3.0
1 stars 0 forks source link

Why doesn't CROSS REF get data include ISSN for journals, just DOI? #9

Closed ssu-readinglists closed 10 years ago

ssu-readinglists commented 11 years ago

This affects linking to SFX properly in some cases

ostephens commented 11 years ago

This is a bug. The ISSN is retrieved from CrossRef, but then incorrectly assigned to the DOI field. The code then discards this as it uses the existing DOI entered for the DOI field.

To correct, need to update /local/references/getdata.php to allocate the ISSN retrieved to the correct field ('sn'). A simple fix that can be applied once the code is up on GitHub

hhy05 commented 11 years ago

Excellent, please apply when ready so we can test.

ostephens commented 11 years ago

After fixing one bug found a deeper issue. This issue needs to be resolved by re-write of how the data fetch process works - see also #6, #15, #16 and #59

ostephens commented 11 years ago

Should work OK with latest code - please test

museli commented 10 years ago

Tested on MyCourse beta on 28th February, 2014. We tested two things: 'are we able to retrieve article-level information from a DOI?'; and 'do specific DOIs still point to the SFX menu, or do they now resolve to the article?'. Both questions are resolved, so this one is fixed. Thanks!

ostephens commented 10 years ago

Closing