search

ssut / nestjs-sqs

A project to make SQS easier to use within NestJS, with decorator-based handling and seamless NestJS-way integration.
MIT License
214 stars 53 forks source link

Update sqs-consumer and sqs-producer to fix graceful shutdown #83

Closed eduardoazevedo3 closed 4 months ago

eduardoazevedo3 commented 5 months ago

Processes in progress are being interrupted before being completed by the Kubernetes deployment or downscale process.

The SQS Consumer and SQS Producer libs already correct this problem. When .stop() is invoked, these libs are already programmed to wait for ongoing processes to finish.

ssut commented 4 months ago

I'm sorry for the very late response. I've now merged this PR and I really appreciate your contribution. This will be included in the next major release, which will drop support for Node.js v16.

cpt-pete commented 4 months ago

@ssut

Great to see this get merged.

Just so you're aware, there is a potential memory leak caused by one of the dependencies of sqs-consumer V10. They bumped the dependency version in v11 to ensure the fix.

It would be great to bump to v11 now.

https://github.com/bbc/sqs-consumer/issues/509

ssut commented 4 months ago

@ssut

Great to see this get merged.

Just so you're aware, there is a potential memory leak caused by one of the dependencies of sqs-consumer V10. They bumped the dependency version in v11 to ensure the fix.

It would be great to bump to v11 now.

bbc/sqs-consumer#509

Thanks for letting me know. I’ll update it very soon, nearly right after my current work.

ssut commented 4 months ago

@ssut

Great to see this get merged.

Just so you're aware, there is a potential memory leak caused by one of the dependencies of sqs-consumer V10. They bumped the dependency version in v11 to ensure the fix.

It would be great to bump to v11 now.

bbc/sqs-consumer#509

FYI: I'm preparing the next release in https://github.com/ssut/nestjs-sqs/pull/85.