search

ssut / wideq-js

A Node.JS(TypeScript) port of wideq, a reverse-engineered client for the LG SmartThinQ API
https://ssut.github.io/wideq-js/
MIT License
18 stars 7 forks source link

Add binary control support #16

Open ncovercash opened 4 years ago

ncovercash commented 4 years ago

Certain kinds of equipment use a binary string instead of key/value pairs to set data.

You can see a detailed example in sampsyo/wideq#12. This string is dynamically generated based on the model's information, therefore, is also more natural and easier to use.

As my refrigerator uses these types of commands, I implemented methods of RefrigeratorDevice which take advantage of this control method. The old ones are left as-is (not renamed) for backwards compatibility. In the future, I would recommend prefixing them with "setKey" for clarity. I plan on making a PR to NorDroN/homebridge-wideq soon which allows setting which mode to use (for different kinds of hardware).

ncovercash commented 4 years ago

Oops, just realized I left some extra console print statements in there. Fixed!