search

ssvlabs / ssv-spec

GNU General Public License v3.0
25 stars 22 forks source link

Use "NextEpoch" duties correctly in duties/newduty #271

Open GalRogozinski opened 1 year ago

GalRogozinski commented 1 year ago

We are not using testingutils.TestingSyncCommitteeDuty*NextEpoch* in newduty/decided like the rest of the tests. From my understanding of the tests, a good happy flow should look like the following:

    Runner:                  decidedRunner(testingutils.SyncCommitteeRunner(ks), &testingutils.TestingSyncCommitteeDuty),
    Duty:                    &testingutils.TestingSyncCommitteeDuty*NextEpoch*

This should start up with a decided runner for some epoch, and then start a duty for the next. But none of the tests follow this pattern.

On the other hand maybe we want to show that it doesn't matter for the spec if we follow the happy flow. Then we should just have all tests be consistent..

_Originally posted by @GalRogozinski in https://github.com/bloxapp/ssv-spec/pull/254#discussion_r1216729161_