QBFT tests leftovers - Commit, Controller - Decided, Prepare, Proposal, Round-Change - Githubissues

ssvlabs / ssv-spec

GNU General Public License v3.0

25 stars 22 forks source link

QBFT tests leftovers - Commit, Controller - Decided, Prepare, Proposal, Round-Change #327

Open MatheusFranco99 opened 10 months ago

MatheusFranco99 commented 10 months ago

Tests

Commit

[x] Decided full data
[x] Invalid full data - Since the commit validation doesn't check the FullData field, it produces no error. Should I include a check, discard this test or just leave it?
[x] Valid full data - Commit validation doesn't check the FullData field, so why this test?

Controller - Decided

[x] Valid full data

Prepare

[x] Duplicate message quorum
[x] Set prepared full data

Proposal

[x] Valid full data

Round Change

[x] Invalid Justification Full Data
[x] Valid Justification Full Data

MatheusFranco99 commented 10 months ago

The test "Set prepared full data" was dropped because it's already tested in the happy flow test.

https://github.com/bloxapp/ssv-spec/pull/327#discussion_r1438870719