fastssz was upgraded in #324 and it changed the roots for ConsensusData, SignedMessage and SSVMessage, which would be a fork.
This fastssz upgrade included a crucial hashing fix, replacing PutBytes with Append in order to prevent double-merkleization in HashTreeRoot methods, thereby changing roots for []byte fields exceeding 32 bytes.
It's noted that Beacon spec tests appear unaffected by this change, as they don't contain fields exceeding the threshold for the double-merkleization bug. However, we don't know that Beacon messages are absolutely not impacted.
Therefore, we propose inspecting the changes in _encoding.go files between the currently and previously imported versions of go-eth2-client, to ensure that any change from PutBytes to Append is encoding a field which can not exceed 32 bytes in size.
Two more changes were done to preserve backwards-compatibility:
Encoding of types.Contribution was copied over from v0.3.4
spec.DataVersion is now being decremented in encodings and incremented in decodings, because all of the values were incremented by 1 in go-eth2-client.
moshe-blox
commented
7 months ago
fastsszwas upgraded in #324 and it changed the roots forConsensusData,SignedMessageandSSVMessage, which would be a fork.This
fastsszupgrade included a crucial hashing fix, replacingPutByteswithAppendin order to prevent double-merkleization inHashTreeRootmethods, thereby changing roots for[]bytefields exceeding 32 bytes.It's noted that Beacon spec tests appear unaffected by this change, as they don't contain fields exceeding the threshold for the double-merkleization bug. However, we don't know that Beacon messages are absolutely not impacted.
Therefore, we propose inspecting the changes in
_encoding.gofiles between the currently and previously imported versions of go-eth2-client, to ensure that any change fromPutBytestoAppendis encoding a field which can not exceed 32 bytes in size.Two more changes were done to preserve backwards-compatibility:
types.Contributionwas copied over fromv0.3.4spec.DataVersionis now being decremented in encodings and incremented in decodings, because all of the values were incremented by 1 in go-eth2-client.