ssvlabs / ssv-spec

GNU General Public License v3.0

25 stars 22 forks source link

Partial Signature Verification Aggregation #369

Closed MatheusFranco99 closed 5 months ago

MatheusFranco99 commented 5 months ago

Overview

This PR implements the reduction of signatures optimization for partial signature messages as described in this SIP.

Changes

Drop SignedPartialSignatureMessage's signature verification.
Stop verifying each beacon signature in favour of verifying the quorum of signatures through the reconstructed signature.
Add fall back function in case the reconstructed signature is wrong.
In case of duplicated different signatures (same signer), verify both and keep the correct one (if any).

Changed tests

[x] Unknown signer: error message
[x] Invalid beacon signature: add a quorum of messages to detect the invalid signature
[x] Invalid signature: drop expected error regarding SignedPartialSignatureMessage's signature

New tests

[x] Invalid quorum then valid quorum: produces an invalid quorum and then sends a fourth valid message to get a valid quorum

Improvement

New total duty time per number of consensus rounds.

1 Round	2 Rounds	3 Rounds
50%	80%	88%

New partial signature quorum processing time: 17%.

MatheusFranco99 commented 5 months ago

@GalRogozinski This PR is for partial signature messages