Closed GalRogozinski closed 2 months ago
For duty tests we skip broadcasted consensus messages: https://github.com/ssvlabs/ssv-spec/blob/548cb4fb149852316f8d46cbf7e62a47a94fafae/ssv/spectest/tests/runner/duties/newduty/test.go#L55-L58
we shouldn't do that... we should test consensus messages as well imo... Maybe it was dont this way to seperate runner from consensus, but we run consensus instance in the test
Add ValueCheck tests
We should test the following scenarios:
invalid_quorum_then_valid_quorum
we should have byzantine test where some roots have a valid root while others don't. We need to see that a 4th message fixes the invalid onesCurrently scenario 3 is implicitly tested because the info is in the broadcasted root (so it is good enough). For 2 we are missing the input.
Done
Runner
Consensus
Duties - New duty
Duties - Attestation Sync Committee
Post-consensus
Value check for beacon vote (committee runner's consensus data)