search

ssvlabs / ssv-spec

GNU General Public License v3.0
25 stars 21 forks source link

Fix runner state in MessageProcessingSpecTest #413

Closed MatheusFranco99 closed 1 month ago

MatheusFranco99 commented 1 month ago

This PR fixes the runner state for the CommitteeRunner test cases in the MessageProcessingSpecTest.

MatheusFranco99 commented 1 month ago

@GalRogozinski Yeah. I see your point. That is exactly it. When using CreateRunnerFn, we create a new Runner to do the duty (that is different from test.Runner). When we don't create a duty, the test.Runner is placed on the runners' map in Committee.

Before, I have also tried using the test.Runner when creating a runner for a duty. But some tests had troubles. I'll try again

GalRogozinski commented 1 month ago

Before, I have also tried using the test.Runner when creating a runner for a duty. But some tests had troubles

I thought it would be simple. If I am wrong and you don't manage to fix this way simply write an explanation of why 🙏

MatheusFranco99 commented 1 month ago

@GalRogozinski Fixed. The tests that had errors were due to using the same Runner for more than one duty. But these tests are now of type CommitteeSpecTest, so all solved :)