search

ssvlabs / ssv-spec

GNU General Public License v3.0
25 stars 22 forks source link

Merge toSignedSSVMessage functions #434

Closed MatheusFranco99 closed 3 months ago

MatheusFranco99 commented 3 months ago

This PR merges the already implemented utility in SSVMessageToSignedSSVMessage to PartialSignatureMessagesToSignedSSVMessage.

y0sher commented 3 months ago

@MatheusFranco99 aren't you removing this function here https://github.com/ssvlabs/ssv-spec/pull/435 ?

MatheusFranco99 commented 3 months ago

@y0sher Yes. Let's wait here. Due to different comments in the PR, I ended up creating two PRs changing the same thing 😅 @GalRogozinski Should this be removed as in https://github.com/ssvlabs/ssv-spec/pull/435 or merged as here? (if not removed, I need to update 435).

GalRogozinski commented 3 months ago

I would just merge and solve conflicts

GalRogozinski commented 3 months ago

Closing this due to #435