This PR introduces the ProcessingMessage structure to be used in the qbft module.
This structure encompasses a SignedSSVMessage and its associated decoded qbft.Message.
The SignedSSVMessage is needed in the qbft module due to QBFT justifications, while the cached qbft.Message in the structure allows us to remove the decoding duplication behaviour.
Usage
We avoid using SignedSSVMessage in qbft as much as possible. The two exceptions are:
the qbft.Controller.ProcessMsg function which is considered the message's entry point to the qbft module. This function transforms the SignedSSVMessage to a ProcessingMessage right away, which is, then, used in the rest of qbft.
the Instance.Broadcast function since we broadcast a SignedSSVMessage (and not a message to be processed).
Thus, ProcessingMessage is used everywhere else, as in MsgContainer, State.ProposalAcceptedForCurrentRound, and in Instance methods.
Overview
This PR introduces the
ProcessingMessagestructure to be used in theqbftmodule.This structure encompasses a
SignedSSVMessageand its associated decodedqbft.Message.The
SignedSSVMessageis needed in theqbftmodule due to QBFT justifications, while the cachedqbft.Messagein the structure allows us to remove the decoding duplication behaviour.Usage
We avoid using
SignedSSVMessageinqbftas much as possible. The two exceptions are:qbft.Controller.ProcessMsgfunction which is considered the message's entry point to theqbftmodule. This function transforms theSignedSSVMessageto aProcessingMessageright away, which is, then, used in the rest ofqbft.Instance.Broadcastfunction since we broadcast aSignedSSVMessage(and not a message to be processed).Thus,
ProcessingMessageis used everywhere else, as inMsgContainer,State.ProposalAcceptedForCurrentRound, and inInstancemethods.