ssvlabs / ssv-spec

GNU General Public License v3.0
25 stars 21 forks source link

Get rid of the `GetShare` pattern that loops over share map #452

Open GalRogozinski opened 1 week ago

GalRogozinski commented 1 week ago

Description

We have places in code where we assume that the first share has common properties with all other committee shares. So we extract the first share to get the data. Even though correct, this is hacky, and we shouldn't do this.

e.g. https://github.com/ssvlabs/ssv-spec/blob/b843e38bfd2696afdd329893ab63246f6412c997/ssv/runner_signatures.go#L49-L58