search

ssvlabs / ssv-spec

GNU General Public License v3.0
25 stars 22 forks source link

`DecidedValue` in BaseRunner has a misleading name. #458

Open GalRogozinski opened 3 months ago

GalRogozinski commented 3 months ago 
          `DecidedValue` in BaseRunner has a misleading name.

If a value was decided on but in the post consensus stage it was rejected due to slashing checks, BaseRunner.DecidedValue will be null while Instance.DecidedValue won't be.

So I propose changing the name here to Value or something else...

_Originally posted by @GalRogozinski in https://github.com/ssvlabs/ssv-spec/pull/457#discussion_r1667627670_