we printed errors instead of returning them

ssvlabs / ssv-spec

GNU General Public License v3.0

25 stars 22 forks source link

we printed errors instead of returning them #460

Open GalRogozinski opened 3 months ago

GalRogozinski commented 3 months ago

On instance.Start() Perhaps we should have proper errors with tests?

_Originally posted by @GalRogozinski in https://github.com/ssvlabs/ssv-spec/pull/371#discussion_r1672008048_

GalRogozinski commented 3 months ago

If we propagate the error from instance.start() then it will "return instance failed to start"... But this isn't true... not sure how to solve this... maybe we should just delete the prints?

y0sher commented 3 months ago

I think it makes more sense that Start can return an error than print.