search

ssvlabs / ssv-spec

GNU General Public License v3.0
25 stars 22 forks source link

Don't process QBFT messages after instance is decided #473

Closed GalRogozinski closed 2 months ago

GalRogozinski commented 2 months ago

Description

Even after an instance is decided we process messages. This is in order to gather more commit messages for Explorer usage. It is unclear why spec should be concerned with explorer. Allowing to process messages after decided can lead to sudden unexpected behaviors like creating extra round changes.

olegshmuelov commented 2 months ago

Just to clarify, the exporter is now operating differently, and we no longer need to gather additional commit messages after an instance is decided. This change was implemented with the merging of PR #1409 into the stage branch.

Additionally, as a reminder, it's still necessary to process post-consensus messages after an instance has been decided.

GalRogozinski commented 2 months ago

@olegshmuelov of course I am only talking about QBFT messages the instance processes