Closed MatheusFranco99 closed 1 month ago
@y0sher Sure Adding back the PKCS1 due to the break issues
@MatheusFranco99 I would create an issue about switching to PKCS8 in the future if its better in any terms, we just need to to this carefully and think about it from a product perspective.
@y0sher Agree 100%. Thanks
@y0sher there is no hinderance now that we switched back to PKCS1 and this can be merged from your perspective?
Other than that looks good to me.
Btw @MatheusFranco99 and @alan-ssvlabs @y0sher, I don't see a reason to open an issue with PKCS8 unless someone can tell me a clear advantage of it that is relevant to us. I understood the tags will be helpful if we ever change our encryption algo, when we do that the encoding can change.
Overview
This PR adjusts the
PemToPrivateKey
andPemToPublicKey
functions to use a secure storage method, removing the deprecated functions that were being used.