search

ssvlabs / ssv-spec

GNU General Public License v3.0
25 stars 22 forks source link

Secure key storage #481

Closed MatheusFranco99 closed 1 month ago

MatheusFranco99 commented 2 months ago

Overview

This PR adjusts the PemToPrivateKey and PemToPublicKey functions to use a secure storage method, removing the deprecated functions that were being used.

MatheusFranco99 commented 2 months ago

@y0sher Sure Adding back the PKCS1 due to the break issues

y0sher commented 2 months ago

@MatheusFranco99 I would create an issue about switching to PKCS8 in the future if its better in any terms, we just need to to this carefully and think about it from a product perspective.

MatheusFranco99 commented 2 months ago

@y0sher Agree 100%. Thanks

GalRogozinski commented 1 month ago

@y0sher there is no hinderance now that we switched back to PKCS1 and this can be merged from your perspective?

y0sher commented 1 month ago

Other than that looks good to me.

GalRogozinski commented 1 month ago

Btw @MatheusFranco99 and @alan-ssvlabs @y0sher, I don't see a reason to open an issue with PKCS8 unless someone can tell me a clear advantage of it that is relevant to us. I understood the tags will be helpful if we ever change our encryption algo, when we do that the encoding can change.