search

ssvlabs / ssv-spec

GNU General Public License v3.0
25 stars 22 forks source link

A spec probably shouldn't care about whether the key is PKCS1 or PKCS8 encoded #485

Closed GalRogozinski closed 1 week ago

GalRogozinski commented 4 weeks ago

A spec probably shouldn't care about whether the key is PKCS1 or PKCS8 encoded

We maybe should consider deleting this code

_Originally posted by @GalRogozinski in https://github.com/ssvlabs/ssv-spec/pull/481#discussion_r1718189128_

y0sher commented 3 weeks ago

IMO this SHOULD be something declared in the spec, so this is standardized ( for example across clients ). I agree spec shouldn't care about which implementation to use, but it should tell all client implementers that they should accept a key encoded in some specific format.

GalRogozinski commented 1 week ago

I agree and I am closing this issue