ssvlabs / ssv-spec

GNU General Public License v3.0
25 stars 22 forks source link

ControllerSpecTest doesn't use OutPutMessagesField #486

Open GalRogozinski opened 2 months ago

GalRogozinski commented 2 months ago
          Notice that not only does none of the implemented tests define it but the spec test itself doesn't use it.

As I see it, the reason is that the controller spec test wants to test decided values and the decided messages for a list of instances (and not the instance's broadcasted messages).

I think that we should either drop this field or implement it in the tests if wanted.

_Originally posted by @MatheusFranco99 in https://github.com/ssvlabs/ssv-spec/pull/484#discussion_r1718211901_