sswelm / KSP-Interstellar-Extended

continuation of KSP Interstellar
Other
98 stars 103 forks source link

Reactor Control Window in VAB broken #687

Closed Cholerix closed 2 years ago

Cholerix commented 3 years ago

With KSP 1.12.2.3167 and Interstellar Extended 1.29.2 the reactor control window doesn't work in the VAB. The window remains empty and stuck in place and the log is spammed with the following message:

[EXC 13:04:52.895] NullReferenceException: Object reference not set to an instance of an object
    FNPlugin.Reactors.InterstellarReactor.Window (System.Int32 windowId) (at <1d33634ee09f4e5abdbfb59994d4c617>:0)
    UnityEngine.GUILayout+LayoutedWindow.DoWindow (System.Int32 windowID) (at <58f888e0d56a4620958c8e58a768c70d>:0)
    UnityEngine.GUI.CallWindowDelegate (UnityEngine.GUI+WindowFunction func, System.Int32 id, System.Int32 instanceID, UnityEngine.GUISkin _skin, System.Int32 forceRect, System.Single width, System.Single height, UnityEngine.GUIStyle style) (at <58f888e0d56a4620958c8e58a768c70d>:0)
    UnityEngine.DebugLogHandler:LogException(Exception, Object)
    ModuleManager.UnityLogHandle.InterceptLogHandler:LogException(Exception, Object)
    UnityEngine.Debug:CallOverridenDebugHandler(Exception, Object)

It appears that vessel is null right here https://github.com/sswelm/KSP-Interstellar-Extended/blob/master/FNPlugin/Reactors/InterstellarReactor.cs#L2630

If null check is added (by passing 0 as mission time) the reactor control window shows up but some entries don't seem to work properly. I'm not sure about the lifetime, resource consumption and production but I thought fusion maintenance used to work in the past. I could be mistaken though, it has been a few years since I last placed with KSP Interstellar. Either way it would be useful to have when building a vehicle.

grafik

Modlist It's only KSP Interstellar with dependencies, some recommendations and some QoL mods for convenience. ``` B9 Part Switch (B9PartSwitch v2.18.0) BetterBurnTime (BetterBurnTime 1.10) Breaking Ground (BreakingGround-DLC 1.7.1) ClickThrough Blocker (ClickThroughBlocker 1:0.1.10.17) Community Resource Pack (CommunityResourcePack 1.4.2) Community Tech Tree (CommunityTechTree 1:3.4.4) Filter Extensions - Plugin (FilterExtensions 3.2.6) Heat Control (HeatControl 0.6.1) Hide Empty Tech Tree Nodes (HideEmptyTechNodes 1.3.0) HyperEdit (HyperEdit 1.5.8.0) Improved Tree Engine Placement (ImprovedTreeEnginePlacement v1.4.0) Interstellar Fuel Switch (InterstellarFuelSwitch 3.29.4) Interstellar Fuel Switch Core (InterstellarFuelSwitch-Core 3.29.4) Interstellar Redistributable (InterstellarRedistributable 1.4) Kerbal Engineer Redux (KerbalEngineerRedux 1.1.9.0) Kerbal Joint Reinforcement Continued (KerbalJointReinforcementContinued v3.5.2) KSP AVC (KSP-AVC 1.4.1.5) KSP Interstellar Extended (KSPInterstellarExtended 1.29.2) KSP Recall (KSP-Recall v0.2.0.6) Module Manager (ModuleManager 4.2.1) Patch Manager (PatchManager 0.0.17.2) Photon Sailor (PhotonSailor 1.7.3) SpaceTux Library (SpaceTuxLibrary 0.0.6.1) The Janitor's Closet (JanitorsCloset 0.3.7.7) Toolbar Controller (ToolbarController 1:0.1.9.6) TweakScale - Rescale Everything! (TweakScale v2.4.5.3) Zero MiniAVC (ZeroMiniAVC 1:1.1.1.1) ```
Cholerix commented 2 years ago

Fixed by #698