sswelm / KSP-Interstellar-Extended

continuation of KSP Interstellar
Other
98 stars 101 forks source link

Fix for thermal and charged particle power taking longer to fill when time warping. #689

Closed drhead closed 2 years ago

drhead commented 2 years ago

Currently, if a reactor's thermal or charged particle power is not full and power demands are low, it will produce enough to fill 0.1% of its unfilled capacity per tick. This does not respect time warp: the same percentage of the bar will fill in a given amount of real-time seconds regardless of the current time warp factor. This results in reactors wasting additional fuel, since reactors consume more fuel while warming up like this, and time warping makes it take longer to warm up completely.

This change makes the bar percentage filled per tick scale with time warp in order to offset this, and with the exception of the effects of other existing time warp related bugs in the reactor code, it should take the same amount of game time and reactor fuel for a reactor to fill its capacity of thermal power and/or charged particles. The base speed where it gets filled (at 1x speed) should be the same.

sswelm commented 2 years ago

sounds like a good suggestion. I only hope it won't cause issues at high time warp