sswelm / KSP-Interstellar-Extended

continuation of KSP Interstellar
Other
98 stars 103 forks source link

VARIES produces solid hydrogen while running #701

Closed Cholerix closed 2 years ago

Cholerix commented 2 years ago

The VARIES Antimatter Catalyzed Fusion Drive produces 1.71 units of solid hydrogen per second while running, resulting in a gain of 0.02 units per second.

This is caused by the method InterstellarReactor.UseProductForPropulsion, which seems to be missing a step: Instead of giving back some propellant, it gives back all of the propellant.

How is this supposed to work? I can create a pull request once I know how to fix it.

Cholerix commented 2 years ago

I think I figured it out. Pull request is open

sswelm commented 2 years ago

the idea is to give back the mass of the fusion products, so they can be used for propulsion. This is especially important for pure fusion mode where the engine is supposed to run on fusion products. The plan was to use the new temporary resource, Charged Particle (which now has a mass), so it can be used by ModuleEngine to generate force, and any excess could be thrown away.