sswelm / KSP-Interstellar-Extended

continuation of KSP Interstellar
Other
97 stars 96 forks source link

Procedural Parts - procedural xenon tank always has default capacity #736

Open bdleitner opened 3 weeks ago

bdleitner commented 3 weeks ago

Copied from this issue as their suggestion was that resource amounts would be handled by InterstellarFuelSwitch. I'm not sure if that's the case, but I'm hoping people can steer me in the right direction if not.

I've been noticing odd behavior before with the procedural xenon tank, like if I revert a launch the tank stays the same size but ends up nearly empty.

I'm using KSPIE (full mod list attached) and just starting to experiment with beamed power so I'm experimenting with warping ships into position just to check out my understanding of how things work before I go launch for real. With my latest craft I noticed that Kerbal Engineer was saying I'd have ~10k dV but then when I moved it into position I only had 91 dV! After some experimenting I was able to determine the following:

I'm not sure if this is caused by another mod interfering, or if there's a bug in the procedural xenon tank when computing capacity outside the VAB such that it always uses the default regardless of tank size.

I uploaded my mod list and KSP.log to this github repo.

My educated guess based on observed behavior would be that when a ship is loaded, the values for amount and maxAmount are recalculated but the capacity is just using the default and not taking the part size into account. Why it only affects procedural xenon tanks and not liquid, ore, or rcs tanks is a mystery to me.

bdleitner commented 3 weeks ago

Wondering if this is related to #725?