search

sswelm / KSPInterstellar

Obsolete
http://forum.kerbalspaceprogram.com/threads/111159-WIP-0-90-KSP-Interstellar-Extended-0-8-5-Improved-NTR-propelants
12 stars 10 forks source link

Inconsistent Pre-flight engine scaling math. #48

Open ConCon2 opened 5 years ago

ConCon2 commented 5 years ago

Attaching a maxed out (I think) 2.5m thermal turbojet to a Mk 4 2.5m peddle bed reactor and setting it to atmosphere the max predicted thrust is about 3,000kN. Scaling it down to 1.875m then back up to 2.5m it says max thrust is 1,687kN. Scaling it up to 3.75m then back to 2.5 it says max thrust 2,500kN. What is happening just based of the info in the engines gui box the "radius" and "exit area" is inconsistent with the scaling slider. The smaller the adjustments of the scale the less significant the radius and exit area inaccuracy. bad engines bad engines 1 bad engines 2 bad engines 3 bad engines 4 I have not tested whether or not this effects there actual performance.

ConCon2 commented 5 years ago

I did a quick test and did confirm that it is only a display bug does not effect physical engine performance. But I did find symmetrically placed engines do not share propellant changes in editor.

sswelm commented 5 years ago

I think it has to do with the radius variable, which was controlled by both external tweakscale and internal tweakscale, I have corrected that already in the next version. I think it was mainly a display editor issue as it would correct itself when switch to inflight. Either way, Please re-evaluate this bug after the release of 1.20.6

ConCon2 commented 5 years ago

Oh... I was wondering why I couldn't find this again I don't know how I ended up on the old git form, sorry about that. So yes it is fixed but it doesn't stay. If you set the engine to 1.25m launch and reload the craft in the hanger it calculates as a 2.5m and still scales up and down independently.

sswelm commented 5 years ago

Damn, that means it worse now. Going to fix that asap