search

st-h / ember-content-editable

A contenteditable component for ember-cli that just works™
MIT License
66 stars 31 forks source link

Disabled attribute doesn't work. #109

Closed axljondelacruz closed 2 years ago

axljondelacruz commented 3 years ago

Hello!

Thanks for making this! Really helps me to not have to write one of my own lol. Though I noticed that when setting disabled, the ember-content-editable class is still on the element and so the css class is still getting applied.

.ember-content-editable {
  cursor: text;
  -webkit-user-modify: read-write-plaintext-only;
}

Would possibly help to throw that into classNameBindings as contenteditable:ember-content-editable?

Update

I see that this relates to Issue https://github.com/st-h/ember-content-editable/issues/105 and PR #99 . Scoping the CSS would work better in this scenario! 👍

st-h commented 2 years ago

sorry about the late reply. This should be now fixed in version 3.0.0. Upgrades require to migrate due to two way binding no longer being available with current ember versions.