search

st-h / ember-content-editable

A contenteditable component for ember-cli that just works™
MIT License
66 stars 31 forks source link

Add peerDependency `ember-source v5` #118

Closed mkszepp closed 1 year ago

mkszepp commented 1 year ago

Atm ember-content-editable has as dependency "ember-source": "^4.0.0" https://github.com/st-h/ember-content-editable/blob/9a37ea72c437bd91f3166cd6a30221477d2e0f5d/package.json#L87-L89

It would be greate to add ember-source v5, otherwise there is not possible to use this addon with ember v5

"peerDependencies": {
    "ember-source": "^4.0.0 || >= 5.0.0"
  },

If you need any help, just tell me, so i will add a PR

st-h commented 1 year ago

Thanks for raising this. Could you please try version 4.0.0-rc.2, which has ember 5 as a peer dependency. Would probably be better to allow ember 4 and 5 as shown in your snippet, though.

mkszepp commented 1 year ago

@st-h thanks! we will try it, when we have all other packages ready for ember v5, because we have some packages which are atm not ready for ember v5. It would be great to allow v4 also for ember v4, so we can already us it.

st-h commented 1 year ago

Sure. Could you please give 4.0.0-rc.6 a try, which has the modified peer dependency?

mkszepp commented 1 year ago

@st-h it looks good ❤️. i have updated the package and it works. Thank you

mkszepp commented 7 months ago

@st-h we are using this rc.6 since months and it works everything fine... I think you can publish it as major release or what do you thing?

st-h commented 7 months ago

Thanks a lot for the feedback. I've published it as 4.0.0 now. Pretty much lost track of it as I don't have much time for ember addons at the moment.