search

st-h / ember-content-editable

A contenteditable component for ember-cli that just works™
MIT License
66 stars 31 forks source link

placeholder not working on Edge - 1.0.0.alpha-3 #41

Closed danieledraganti closed 6 years ago

danieledraganti commented 6 years ago

Hello, I have updated to Alpha 3 for a project I'm working on, but on Edge, instead of setting the placeholder in case the value is null, it will just show "null" as a content. Works fine on Safari and Chrome. Will roll back to pre-1.0.0 since it I am on a release cycle.

st-h commented 6 years ago

Thank you for reporting this. Would you please mind verifying this on the demo page? I added two fields to the bottom of the page, which have undefined and null as value and a placeholder set. Both work fine using the edge 41 VM provided by microsoft as seen here: edge

Links to source: template, controller

Does this only affect specific versions of edge or are you seeing an entirely different issue?

The 1.0.0 rewrite did not really touch anything related to placeholders, however I probably might have overlooked something. But this will be difficult to fix unless we have a way to reproduce.

danieledraganti commented 6 years ago

Just tested it on Edge, v. 40.15063.674.0, HTML 15.15063. This is what I have:

null-edge

Apparently, null value DOES mess up with Edge...

st-h commented 6 years ago

@danidr would you mind checking alpha.4 regarding this? I might have had an idea what might be causing this, even though it seems a little strange that this only appears in certain browser versions.

danieledraganti commented 6 years ago

Tried the demo page on Edge again, and the placeholder now appears correctly. Thanks for the quick fix!