st-h / ember-content-editable

A contenteditable component for ember-cli that just works™
MIT License
66 stars 31 forks source link

Watermark color incorrect #6

Closed friksa closed 9 years ago

friksa commented 9 years ago

The placeholder color should not be modified as it is too hard to override in app.css.

Preferably it should be provided as a property that can be set with a default value of #cccccc.

[contenteditable=true]:empty:not(:focus):before {
  content: attr(placeholder);
  color: rgba(0,0,0,0.6);//remove this line or use attr(watermarkcolor)
}

By not specifying it, I can override it more easily in app.css

.ember-content-editable:empty {
  color: #cccccc;
}
chrissloey commented 9 years ago

Thanks, I've moved where it is specified to match your second block of code - that way the default styling can remain and overriding it is simple :)

Fix is in 0.3.2.