search

st-h / ember-content-editable

A contenteditable component for ember-cli that just works™
MIT License
66 stars 31 forks source link

Add a webkit specific css property to fix #83 #84

Closed dmzza closed 5 years ago

dmzza commented 5 years ago

The -webkit-user-modify property was missing from the CSS.

With this property set on all [contenteditable] elements, Safari and Chrome deal with line breaks correctly. Additionally, it is just the right thing to do.

I used read-write-plaintext-only because this ember addon does not preserve rich text formatting from pasted text.

See Related Safari Documenation

st-h commented 5 years ago

The MDN page on that is interesting as well https://developer.mozilla.org/en-US/docs/Web/CSS/user-modify I am little surprised that this is needed, however I currently do not see any downsides on adding the property. Thanks for the PR.

st-h commented 5 years ago

released 1.0.4

dmzza commented 5 years ago

Thanks for accepting this so quickly and releasing a new version with the latest dependencies. The addon has been a pleasure to use!