search

st-one-io / node-open-protocol

This node is an implementation of the Atlas Copco's Open Protocol. This node was created by Smart-Tech as part of the ST-One project.
GNU General Public License v3.0
36 stars 35 forks source link

Add LastPowerMACSTighteningResultStationData MID 0106 #16

Closed ferm10n closed 5 years ago

gfcittolin commented 5 years ago

I've just fixed a small issue where, according to the specs, the bolt parameters should repeat for each bolt instead of only once. Could you check it out and test it? If ok, then we can merge it

ferm10n commented 5 years ago

Ah okay that makes sense. Unfortunately I do not have access to a powermacs tool that isn't being used in production at the moment. However, there's a chance that I might have an opportunity in the next few months? Sorry I can't check it out now.

gfcittolin commented 5 years ago

I also don't have any PM available for testing. Therefore, I've handcrafted a telegram by looking at the docs, and then I wrote a unit test for it. Should be enough for now. If we find out any bug or improvement we can release a new version with them

All PRs just landed on the just published v1.1.0. Thank you once again for the contributions!