st-one-io / node-red-contrib-s7

A Node-RED node to interact with Siemens S7 PLCs
GNU General Public License v3.0
111 stars 58 forks source link

adjust i18n language code #47

Closed Lichtjaeger closed 5 years ago

Lichtjaeger commented 5 years ago

Looks like the "Accept-Language" header does not make a difference between "de-DE", "de-AT" or "de-CH" in some browsers.

We need to rename the i18n folder to "de" to make it work in all browsers. Maybe it would make sense to rename the "en-US" folder to simply "en" too.

In addition, I reworded 2 lines to make them feel more "natural".

Sorry for the extra work.

gfcittolin commented 5 years ago

Never mind, I'm merging and publishing it. I've checked Node-RED's locales folder and they use a de folder and a en-US one, so i think we can keep the English one