Closed yokawasa closed 2 years ago
Given the suggestion like https://github.com/st-tech/gatling-operator/pull/1#discussion_r733460033, I added check if cloud storage info is given, and skip the reporter job in the case that prerequistes are not met https://github.com/st-tech/gatling-operator/pull/1/commits/437ea7b03d7ac264eab3e53886b2040842f5653e
I was wondering about the behavior on rerun. It's not necessary to fix the minor points.
Please see the comment I made in the thread https://github.com/st-tech/gatling-operator/pull/1#discussion_r740047892, Also please check the following updates I made based upon your comments:
@akitok @niqniqniqq @tmrekk121 thanks a lot for the review! I go ahead to merge the PR
Descriptions
Initial version of gatling operator which is copied from PoC repository
Huge apologies for being a huge PR π π
:memo: Please be noted that all comments are expected to be made in English
Tests
Local k8s/kind cluster
Preparations for the tests
First, create local Kind cluster
Check if the kind cluster named
gatling-cluster
is createdThen, deploy controller to the kind cluster
Check the CRD for gatling-operator is deployed
Check if gatling-operator is running
Deploy sample gatling CR to the local cluster
For testing01, deploy sample gatling CR named
gatling-sample01
to the cluster withmake kind-sample-deploy
Check if gatling CR is deployed and then if relevant job and pods are created
For testing02, deploy sample gatling CR named
gatling-sample02
to the cluster withkubectl apply
Check if gatling CR is deployed and then if relevant job and pods are created
Checklist
spec.cleanupAfterJobDone: true
, all relevant resources for gatling CR such as job, pods are deleted after all gatling jobs are completed.Remote k8s cluster
Preparations for the tests
:memo: in the following description, we use AWS ECR for the private container registry
717397055837.dkr.ecr.ap-northeast-1.amazonaws.com/gatling-operator:<tag>
717397055837.dkr.ecr.ap-northeast-1.amazonaws.com/gatling:<tag>
First, deploy controller to the k8s cluster
Check the CRD for gatling-operator is deployed
Check if gatling-operator is running
Deploy sample gatling CR to the remote k8s cluster
For testing01, deploy sample gatling CR named
gatling-sample01
to the cluster withmake sample-docker-push
andmake sample-deploy
First, Push a sample gatling image to container registry
π Ensure that you're logged into your docker container registry that you will be using as the image store for your K8s cluster if not yet done!
After you push the sample gatling container, deploy the Gatling CR to your cluster:
Check if gatling CR is deployed and then if relevant job and pods are created
For testing02, deploy sample gatling CR named
gatling-sample02
to the cluster withkubectl apply
Check if gatling CR is deployed and then if relevant job and pods are created
Checklist
spec.cleanupAfterJobDone: true
, all relevant resources for gatling CR such as job, pods are deleted after all gatling jobs are completed.spec.generateReport: true
, spec.cloudStorageSpec like below, reporting data is generated and stored in a specified cloud storage (s3 bucket).spec.notifyReport: true
, spec.notificationServiceSpeclike below, gatling reporting result is reported to your specified slack channelsecret
namedgatling-notification-slack-secrets