st-tech / gatling-operator

Automating distributed Gatling load testing using Kubernetes operator
MIT License
68 stars 21 forks source link

add GCS related implementation / add toleration, serviceAccountName to PodSpec #2

Closed kayamin closed 2 years ago

kayamin commented 2 years ago

Description

Tested against GKE environment

❯ make docker-build

❯ docker tag gatling-operator:20220113-105928 gcr.io/xxxx/gatling-operator:20220113-105928

❯ docker push gcr.io/xxxx/gatling-operator:20220113-105928
The push refers to repository [gcr.io/xxxx/gatling-operator]
f5572929da88: Pushed
5b1fa8e3e100: Layer already exists
20220113-105928: digest: sha256:f3ae2e202c505f7e29bcfbf49a800e6cb2edfb96fd56e6facc8d67cb985f2652 size: 739

❯ k edit deploy gatling-operator-controller-manager

❯ k get pod
NAME                                                   READY   STATUS      RESTARTS   AGE
gatling-operator-controller-manager-69f6fcb868-kqmhn   2/2     Running     0          96m
❯ k get job
NAME                        COMPLETIONS   DURATION   AGE
gatling-sample01-reporter   1/1           43s        38m
gatling-sample01-runner     2/2           101s       40m

❯ gsutil ls gs://xxxx-gatling-operator-reports/gatling-sample01/861712401/
gs://xxxx-gatling-operator-reports/gatling-sample01/861712401/gatling-sample01-runner-gcljk.log
gs://xxxx-gatling-operator-reports/gatling-sample01/861712401/gatling-sample01-runner-ng5cd.log
gs://xxxx-gatling-operator-reports/gatling-sample01/861712401/index.html
...
yokawasa commented 2 years ago

@kayamin Thanks for the contribution! All features that you've added looks great!

One additional request: Would you please change the following comment parts to like Supported providers: "aws", "gcp" from Supported providers: "aws"? https://github.com/st-tech/gatling-operator/blob/ce702d6a584cdfb11c2830ed3682edf3273ae8a4/api/v1alpha1/gatling_types.go#L139 https://github.com/st-tech/gatling-operator/blob/ce702d6a584cdfb11c2830ed3682edf3273ae8a4/config/samples/gatling-operator_v1alpha1_gatling01.yaml#L31 https://github.com/st-tech/gatling-operator/blob/ce702d6a584cdfb11c2830ed3682edf3273ae8a4/config/samples/gatling-operator_v1alpha1_gatling02.yaml#L26

kayamin commented 2 years ago

@yokawasa Thank you for a comment. I reflected your suggestion. Please check again 😄