st-tu-dresden / videoshop

SalesPoint sample application
Apache License 2.0
87 stars 246 forks source link

Improve implementation of `Customer` #156

Closed odrotbohm closed 2 years ago

odrotbohm commented 2 years ago

The aggregate Customer is not implemented correctly. It's lacking a equals(…)/ hashCode() implementation based on its identifier. This currently doesn't cause any issues but could if they'd be held in a collection like a Set. Ideally, it'd implement Salespoint's AbstractAggregateRoot and a dedicated SalespointIdentifier.