search

st0ffern / gl-react-imagefilters

Image filters for gl-react and gl-react-native
48 stars 7 forks source link

Dependencies issues #15

Open ghost opened 6 years ago

ghost commented 6 years ago

HI @stoffern. I tried to use this module with latest React and gl-react@^2.2.5 but I faced couple of issues:

Feel free to let me know if I'm doing something wrong or if that's known issues; I'd be able to come with PR for the PropTypes error; not sure how what to do with gl-react-sharpen.

ghost commented 6 years ago

I've submitted PRs to gl-react-sepia (https://github.com/stoffern/gl-react-sepia/pull/3), gl-react-hue-rotate (https://github.com/gre/gl-react-hue-rotate/pull/3) and gl-react-negative (https://github.com/gre/gl-react-negative/pull/2) to fix the PropTypes.

st0ffern commented 6 years ago

Great work! 👍 I am updating now all repos and this one. Should be on NPM within the hour

ghost commented 6 years ago

@stoffern Any hints on the second error? Error message is pretty straight forward, but package.json explicitly state usage of v2.

st0ffern commented 6 years ago

I am working on a solution to this now.. Deps are upgraded to gl-react v3 and i want it to be at v2 until v3 is ready for usage..

mopilo commented 6 years ago

done with the solution?