st0ffern / react-native-image-cropper

Crop your images with zoom and pan
https://www.npmjs.com/package/react-native-image-cropper
MIT License
158 stars 67 forks source link

glsl issue #50

Closed leuxcid closed 6 years ago

leuxcid commented 6 years ago

Im trying to upgrade my app to react native 50, and after updating to the latest version of this plugin i am getting an error GLSL is only available in gl-react v2. What versions of gl react and gl react native should i be using?

I currently have "react": "16.0.0", "react-native": "0.50.4", "gl-react": "2.3.1", "gl-react-native": "2.47.0", "react-native-image-cropper": "^0.4.1",

glsl
notme001 commented 6 years ago

Hello Downgrading react-native-image-cropper to version 0.4.0 solved the problem for me

wmcbain commented 6 years ago

@notme1994 That's not really helpful for anyone using React Native above 0.50 as that depends on React 16.

Seeing the same issue too here with the same exact error.

Trying to upgrade to React Native 0.50.3

deejaygeroso commented 6 years ago

I agree with @wmcbain .. also encountering the same problem..

I think one work around, which I haven't tried, for now is downgrading react-native-image cropper to version 0.4.0 then just manually edit the PropTypes of the packages under node modules which is too much of a hustle..

st0ffern commented 6 years ago

will look into it today. I guess it is the update of gl-react-image that is the problem.

st0ffern commented 6 years ago

Can anyone test if v0.4.3 works and report back?

leuxcid commented 6 years ago

Bug #49 comes back on 0.4.3

st0ffern commented 6 years ago

Try latest, 0.4.4 should fix it 0ca54371d26fedf4367115486fc990f8825e1fc2 Moved gl-react-image into this repo and made a fix for it

st0ffern commented 6 years ago

better?

wmcbain commented 6 years ago

This is what I get with 0.4.4:

screen shot 2017-12-15 at 1 41 49 pm

0.4.3 worked for me @leuxcid, you sure you were running with clean cache?

st0ffern commented 6 years ago

This problem is solved now with latest version, remember to do

rm -rf node_modules
npm i 

or

yarn install
st0ffern commented 6 years ago

working on latest release