st0ffern / react-native-image-cropper

Crop your images with zoom and pan
https://www.npmjs.com/package/react-native-image-cropper
MIT License
158 stars 71 forks source link

panToMove, pinchToZoom, maxZoom and MinZoom ignored #65

Open Fsarmento opened 6 years ago

Fsarmento commented 6 years ago

I just followed the example on index.md and everything works great, except that if I change the values of maxZoom and minZoom, or set panToMove to false or pinchToZoom to false, nothing changes. Ie, I can still pinch and pan with panToMove={false} pinchToZoom={false} and zoom up A LOT (would say 100x) even if I set maxZoom to 1, 2 or 3.

    <ImageCrop
      ref={props.cropperRef}
      image={props.path}
      cropHeight={screenSize.height}
      cropWidth={screenSize.width}
      zoom={100}
      maxZoom={100}
      minZoom={20}
      panToMove={false}
      pinchToZoom={false}
    />

Looking at the code (ImageCrop.js), I see no reference to these props being used: panToMove, pinchToZoom, maxZoom and minZoom (panToMove and pinchToZoom are not even defined on ImageCrop.propTypes).

dinotrnka commented 5 years ago

The same issue is happening to me too. Those fields are definitely ignored. The solution is to either fork the repo or copy/paste Image.js and ImageCrop.js into your own project and make the modifications yourself.

st0ffern commented 5 years ago

https://github.com/stoffern/react-native-image-cropper/issues/71