search

st235 / ExpandableBottomBar

A new way to implement navigation in your app 🏎
MIT License
783 stars 58 forks source link

added dimen file and replaced static dimen #99

Closed vidyajejurkar closed 7 months ago

st235 commented 1 year ago

Hello @vidyajejurkar

Thank you for using the library and for your contribution!

Can you, please, elaborate a bit in the PR description on why the codebase needs the change? It would be much easier to review the changes if I have more context on them.

Looking forward to hearing from you.

Best regards, Alex

st235 commented 7 months ago

It seems that the pull request is stale. I don't see practical value in merging the changes as the goal is still unclear and all of them are related to the sample app.

I will close the issue for now. Feel free to re-open whether you think that the changes should be merged.