st3v3nmw / obsidian-spaced-repetition

Fight the forgetting curve by reviewing flashcards & entire notes on Obsidian
https://www.stephenmwangi.com/obsidian-spaced-repetition/
MIT License
1.6k stars 190 forks source link

Flashcards not displayed on iPhone #1134

Open alberti42 opened 1 month ago

alberti42 commented 1 month ago

Describe the bug

The flashcards are not visible or just very poorly visible on the iPhone. I am running version 1.13.1

To Reproduce

Open any flash cards or just the list of decks

Expected behavior

Just to see the flash card full screen

Screenshots

IMG_0194

OS of your device

iPhone

Obsidian version

1.6.7

Plugin version

1.13.1

Installer version

No response

Additional context

No response

Config file

No response

alberti42 commented 1 month ago

In the new version the plugin is still unusable on mobile devices. I will revert to some old versions.

Please could you confirm you are able to reproduce the bug?

st3v3nmw commented 1 month ago

Please could you confirm you are able to reproduce the bug?

Hi, On my phone (Android, Samsung), it has the same problem when in landscape orientation. I've been using in portrait.

In the new version the plugin is still unusable on mobile devices.

I'll try fix this as soon as I can. I'm traveling for the next week or so though.

alberti42 commented 1 month ago

The new CSS makes no sense to me. It is not helpful. Even on the desktop, the screen is now too small. Fortunately it is easy to overwrite the settings. What was the reason for this change, which reduces the functionality for everyone who uses the plugin seriously? Probably the new settings are helpful for those who have very little content in the flashcards.

And course, thank you for looking into it! I now how much time and passion you put it into it. But this step goes in the wrong direction, in my opinion.

alberti42 commented 1 month ago

The CSS style is even hardcoded: style="height: 80%; max-height: 80%; width: 40%; max-width: 40%; At least this is what it looks like from a first inspection. This is not good practice. Much better to use CSS styles. 40% width makes no sense, especially on mobile phones.

alberti42 commented 1 month ago

Here is the fix for everybody who like me dislike the new settings. Add this to your custom css settings in Obsidian:

#sr-modal {
    width: 90% !important;
    max-width: 100% !important;
}
Bemji99 commented 1 week ago

I tried deactivating "Show context in cards" in the User Interface Menu and the cards seem to work fine now. Kind of a bummer, I really liked the added context.