[BUG] webm doesn't work

st3v3nmw / obsidian-spaced-repetition

Fight the forgetting curve by reviewing flashcards & entire notes on Obsidian

https://www.stephenmwangi.com/obsidian-spaced-repetition/

MIT License

1.53k stars 184 forks source link

[BUG] webm doesn't work #289

Closed superouioui closed 2 years ago

superouioui commented 3 years ago

Describe the bug Unable to listen to webm recordings.

! [[Recording 20210826175024.webm]]

To Reproduce

Recording a sound with the core plugin 'Audio recorder'.
Made a flashcard with the balise ![[yourSound.webm]]
Test in preview
That works
Test in flashcard
that doesn't work

Screenshots Edit:

Preview:

Flashcard:

Versions (please complete the following information): OS: Windows 10 / Android 10 Obsidian version: v0.12.15 Plugin version: v1.6.2

superouioui commented 3 years ago

same problem with mp3

GollyTicker commented 3 years ago

As a frequent user of obsidian-spaced-repetition, I also +1 this, as I would highly appriciate if generally meida embeddings and possibly iframes work in flashcards the same way how they do in the normal preview.

I am not sure however, whether this is really a bug. After all, the feature set only says that images and latex etc work - but not media in general.

If this behavior currently is expected, then this issue might be an enhancement.

careilly commented 3 years ago

Definitely an enhancement: the code seems to handle only IMG embeds. (Actually, treats any embed that isn’t a markdown file as an image.)

careilly commented 3 years ago

I have mp3s working on my local version, I’ll workout webm and how to do a pull request.

There must be a more general purpose embedding api that could be used here, but that’s not a quick fix.

Avinash-Bhat commented 2 years ago

looks like the release for this is not yet done. @st3v3nmw any ETA on that?

st3v3nmw commented 2 years ago

Hi all, audio and video now work in the new release (v1.7.0). Thanks to @careilly's work!