st3v3nmw / obsidian-spaced-repetition

Fight the forgetting curve by reviewing flashcards & entire notes on Obsidian.md
https://www.stephenmwangi.com/obsidian-spaced-repetition/
MIT License
1.5k stars 184 forks source link

[BUG] Card decks aren't completely randomized #514

Open putzwasser opened 1 year ago

putzwasser commented 1 year ago

Describe the bug I turned on the setting RANDOMIZE_CARD_ORDER: "Randomize card order during review?". I thought obsidian-SR would shuffle all individual cards in a deck, but it does not. I guess, it just fetches a random note containing flashcards, but it presents all flashcards of a specific note.

To Reproduce

  1. Turn on RANDOMIZE_CARD_ORDER: "Randomize card order during review?"
  2. Create a deck with some notes that contain multiple flashcards each
  3. Get presented all flashcards of a specific note in a row

Expected behavior It would be better if the deck would be shuffled on a per flashcard basis and not a per note that contain flashcard basis. Maybe a second option would be best to suit everybodies needs

Additional context I write notes as atomic as i can. Then I create a separate flashcard note. I add clozes and q&a to that flashcard note. Some questions are variations of the clozes or other questions. But in general the flashcards' contents are very related.

Seeing the clozes and then immediately the questions defeats the purpose. Being asked multiple questions about the same topic is very boring and I guess it woudl enhance learning if you'd be asked the questions not in a straight row.

ronzulu commented 1 year ago

Hey there, this has been fixed but not yet formerly released. So keep an eye out.

@st3v3nmw I hadn't noticed that this was fixed as part of https://github.com/st3v3nmw/obsidian-spaced-repetition/pull/751.

Do you want me to document that anywhere?

ronzulu commented 11 months ago

Hey @putzwasser

I've implemented some relevant enhancements and would appreciate feedback before I request @st3v3nmw to merge into the official release.

Details are at: https://github.com/st3v3nmw/obsidian-spaced-repetition/issues/610#issuecomment-1793450384

One appropriate setting would be: 280527828-84471970-e2ea-4f6e-baf4-113e2028e8b8

Cheers Ronny

ronzulu commented 9 months ago

Hi @putzwasser the fix has been included in the latest release 1.11.0. Please close this at your convenience.

Cheers Ronny