[BUG] The edits are not applied to the review modal when editing the flashcard inside of the modal

st3v3nmw / obsidian-spaced-repetition

Fight the forgetting curve by reviewing flashcards & entire notes on Obsidian.md

https://www.stephenmwangi.com/obsidian-spaced-repetition/

MIT License

1.37k stars 175 forks source link

[BUG] The edits are not applied to the review modal when editing the flashcard inside of the modal #718

Open Cyfine opened 11 months ago

Cyfine commented 11 months ago

Describe the bug The edits of the flashcard are applied when editing in the flashcard modal, but the edits are applied to the source file.

To Reproduce Steps to reproduce the behavior:

Go to 'Review flashcards'
Click on 'flashcards', go review flashcards
Edit the flashcard, then click save

Expected behavior The flashcard should be updated.

Versions (please complete the following information):

OS: MacOS 13.4.1(c)
Obsidian version: Version 1.3.5 (Installer 1.3.4)
Plugin version: v1.10.1
If on desktop, Installer version: '5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) obsidian/1.3.4 Chrome/112.0.5615.183 Electron/24.3.1 Safari/537.36'

ronzulu commented 9 months ago

Hey there

I started working on this and it's surprising involved to implement.

Then I thought that it actually might be reasonable to simply skip the question after it is edited.

Whilst editing, the user sees the full question and answer, and so it doesn't seem very beneficial for the person to then be immediately questioned on it.

And skipping the question post edit should be easy to implement :slightly_smiling_face:

What do you think?

Cheers Ronny

andmckay01 commented 8 months ago

Imagine you are studying and you want to format the question or answer better.

The best possible UX is to have whatever the user edits to be immediately visible so they can ensure it looks the way they intend. Instead, whatever the user edits is not updated in the modal. There's no feedback at all that the edit was successfully applied.

This seems like a worthwhile change to implement. I'm going to take a stab at it.

Mckay

4Source commented 5 months ago

Once I find something I want to edit, I try to answer the question first and then edit it. Therefore, in my opinion, skipping is not the best way, especially if you want to check whether the changes had the expected effect.

jvdevlab commented 4 months ago

Second that. With multiline answers, I find typos and formatting issues that I want to fix while have things open. Without modal updating it's hard to tell if things where edited properly or not.