st3v3nmw / obsidian-spaced-repetition

Fight the forgetting curve by reviewing flashcards & entire notes on Obsidian
https://www.stephenmwangi.com/obsidian-spaced-repetition/
MIT License
1.53k stars 184 forks source link

[BUG] Plugin not picking up certain flashcards #915

Closed bgreenawald closed 6 months ago

bgreenawald commented 7 months ago

Describe the bug The plugin suddenly only picks up ~half of the flashcards in my Vault. As of a few days ago, I had nearly 500 flashcards, but when I loaded the flashcard review today, it only showed that I had around 250 flashcards. I can confirm that all the other flashcards are still in the Vault and found an example of a file with flashcards past their review date that weren't being picked up at all. I currently don't see any pattern between what it picks up and what it doesn't.

Versions (please complete the following information):

ronzulu commented 7 months ago

Hi @bgreenawald

Thanks for letting us know.

Could you please post (as attachment, not copy/paste) a markdown file that contains flashcard(s) that don't appear in the review modal.

Also, please attach the plugin's settings file, located e.g. D:\Obsidian\.obsidian\plugins\obsidian-spaced-repetition\data.json

Cheers Ronny

bgreenawald commented 7 months ago

Hi Ronny,

Thanks for the quick response. Attached is an example file that isn't showing up. Here is a picture of the current review screen: image

Best, Ben

Avicenna.md data.json

Garg0yle commented 7 months ago

I'm having the same issue all of a sudden. From about 50-60 flashcards in my vault to 2. Here are attachments. Thanks for your work on this plugin btw

The Taliban at war_ 2001-2018.md

data.json

Yury-Dictum commented 6 months ago

Hi! Same problem here. Two days ago there used to be around 130 cards in the queue, now there are none.

3. 🚮 giving smb a hard time.md

data.json

Sorry, forgot to include the environment info. I'm on Win10 Obsidian 1.5.11 plugin version 1.12.1

I'm not sure what is meant by 'installer version'. If it's about Obsidian, the installer version is the same as the release version.

ronzulu commented 6 months ago

Thanks, I can reproduce the problem now, hopefully fixed tomorrow

Scicily commented 6 months ago

I'm having the same issue all of a sudden, too.

OS: macOS Sonoma 14.4

Obsidian version: 1.5.11

Plugin version: 1.12.1

ronzulu commented 6 months ago

Hi all

Beta release is now available.

There is a file called main.js in this zip file main_915A.zip

You will need to copy that to the obsidian plug-in folder, e.g. D:\Obsidian\Obsidian\.obsidian\plugins\obsidian-spaced-repetition

Then reload the plug-in, or restart obsidian.

Any feedback appreciated.

Ronny

Effeh commented 6 months ago

No change for me with the beta version. I use the "convert ==highlights== to clozes" function, and created 20 flashcards earlier today, but none of them are getting picked up even with the new version

ronzulu commented 6 months ago

@Effeh

Could you please post (as attachment, not copy/paste) a markdown file that contains flashcard(s) that don't appear in the review modal.

Also, please attach the plugin's settings file, located e.g. D:\Obsidian\.obsidian\plugins\obsidian-spaced-repetition\data.json

lukeh2313 commented 6 months ago

I am also having the same issue, only one deck of my 7-8 decks are showing up with no change after trying your beta version.

Edition Windows 10 Home OS build 19045.4170

Obsidian version: 1.5.11

Plugin version: 1.12.1

Example note that doesn't show up: dividends vs share repurchases.md

Data: data.json

Thanks for the support!

Effeh commented 6 months ago

Requested files for @ronzulu

same OS/versions as lukeh

This Is My Body.md data.json

ronzulu commented 6 months ago

Hi @Effeh

Your issue may appear the same as others on this topic, but actually is different.

There is a blank line at the very start of your file, i.e. line (1) in the following:

image

This means that the tags: Chinese is not recognized by Obsidian as frontmatter.

Simply remove that blank line, and it should work.

After deleting the blank line, Obsidian recognizes this as frontmatter and renders that section in a special manner

image

ronzulu commented 6 months ago

Hi @lukeh2313

There were significant code changes in plugin version 1.12 to support:

It didn't occur to me that someone might place the topic tag on the line immediately following the last line of a question, and I didn't code for it.

For example, you have:

Why might a company prefer to repurchase shares over the issuance of a dividend?
?
1. Avoids double taxation, first at a corporate level (dividends are not tax deductible) then at individual income tax level when dividends are distributed.
2. Share repurchases inflate EPS by reducing number of shares outstanding which may increase company share price.
3. Share repurchases signal to the market that management believes its shares are undervalued, which might be seen as a good signal.
4. Once dividends are started, they are typically expected to continue. Stopping dividend payments is seen very poorly by the markets and are interpreted as a sign of lower future profits.
#wsp-red <!--SR:!2024-03-26,1,210-->

It should work if you move the topic tag #wsp-red to before the question, e.g.:

#wsp-red
Why might a company prefer to repurchase shares over the issuance of a dividend?
?
1. Avoids double taxation, first at a corporate level (dividends are not tax deductible) then at individual income tax level when dividends are distributed.
2. Share repurchases inflate EPS by reducing number of shares outstanding which may increase company share price.
3. Share repurchases signal to the market that management believes its shares are undervalued, which might be seen as a good signal.
4. Once dividends are started, they are typically expected to continue. Stopping dividend payments is seen very poorly by the markets and are interpreted as a sign of lower future profits.
<!--SR:!2024-03-26,1,210-->

Cheers Ronny

bgreenawald commented 6 months ago

Beta version fixed the issue for me. Thanks for the quick fix!

Best, Ben

Scicily commented 6 months ago

Thx for your help. I'll try it latter. (mac OS, it's hard to find the file to me...)

Scicily

Effeh @.***> 於 2024年3月26日 週二 下午6:43寫道:

Requested files for @ronzulu https://github.com/ronzulu

This Is My Body.md https://github.com/st3v3nmw/obsidian-spaced-repetition/files/14757039/This.Is.My.Body.md data.json https://github.com/st3v3nmw/obsidian-spaced-repetition/files/14757046/data.json

— Reply to this email directly, view it on GitHub https://github.com/st3v3nmw/obsidian-spaced-repetition/issues/915#issuecomment-2020091674, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASYRUC74UNY6SN3APSGJ6PDY2FGOZAVCNFSM6AAAAABFDVKFVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRQGA4TCNRXGQ . You are receiving this because you commented.Message ID: @.***>

lukeh2313 commented 6 months ago

Thanks Ronny, that is working now!

Effeh commented 6 months ago

Thanks Ron. Sorry about the confusion. I'm not sure how that happened---I've been using the same template file for quite a while, and the problem only cropped up very recently. All fixed now regardless

huetruong commented 6 months ago

I'm just coming here because all my cards doesn't show up even in 1.12.2.

Here's an example

AZ305ST1-Q60.md

Scicily commented 6 months ago

same me! QQ

Hue Truong @.***> 於 2024年3月31日 週日 上午1:03寫道:

I'm just coming here because all my cards doesn't show up even in 1.12.2.

Here's an example

AZ305ST1-Q60.md https://github.com/st3v3nmw/obsidian-spaced-repetition/files/14812721/AZ305ST1-Q60.md

— Reply to this email directly, view it on GitHub https://github.com/st3v3nmw/obsidian-spaced-repetition/issues/915#issuecomment-2028293834, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASYRUC7YU4QHJQDWXELOEKLY23V7JAVCNFSM6AAAAABFDVKFVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRYGI4TGOBTGQ . You are receiving this because you commented.Message ID: @.***>

ronzulu commented 6 months ago

Hi @huetruong thanks for posting the markdown file.

Your specific issue is being addressed under [BUG] Unable to recognize multi-line card that begins immediately after the frontmatter's closing line

@Scicily There might be multiple reasons why you are experiencing this. Please post a markdown file that exhibits the problem (attach, don't copy/paste)

Cheers Ronny

huetruong commented 6 months ago

@ronzulu Please don't strip away my special character I used to separate the paragraphs. The last time I used a space, " ", in a blank line, it was strip away with strip() to remove whitespace.

ronzulu commented 6 months ago

Please don't strip away my special character I used to separate the paragraphs. The last time I used a space, " ", in a blank line, it was strip away with strip() to remove whitespace.

Hi @huetruong, is your comment related to this issue? If so, please give further explanation.

Scicily commented 6 months ago

Hello,

I am currently facing an issue where I cannot display the review cards correctly. Since I am using a Mac Sonoma version 14.4.1, I am not quite sure how to locate the MD file you mentioned. If possible, could you please instruct me on how to proceed? Thank you very much.

Sincerely Scicily

Ronny Zulaikha @.***> 於 2024年3月31日 週日 下午6:54寫道:

Hi @huetruong https://github.com/huetruong thanks for posting the markdown file.

Your specific issue is being addressed under [BUG] Unable to recognize multi-line card that begins immediately after the frontmatter's closing line https://github.com/st3v3nmw/obsidian-spaced-repetition/issues/922

@Scicily https://github.com/Scicily There might be multiple reasons why you are experiencing this. Please post a markdown file that exhibits the problem (attach, don't copy/paste)

Cheers Ronny

— Reply to this email directly, view it on GitHub https://github.com/st3v3nmw/obsidian-spaced-repetition/issues/915#issuecomment-2028640664, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASYRUC4WXN4TT37O4JSZ7JTY27TPRAVCNFSM6AAAAABFDVKFVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRYGY2DANRWGQ . You are receiving this because you were mentioned.Message ID: @.***>

huetruong commented 6 months ago

@ronzulu Please don't strip away my special character I used to separate the paragraphs. The last time I used a space, " ", in a blank line, it was strip away with strip() to remove whitespace.

A few months ago, a trim function was introduced which broke my flashcards. Currently, I am using a zero-width character to prevent the trim function from deleting my intentionally added blank lines, which make the flashcards easier to read. I am requesting that you take note of this issue to ensure that it does not occur again in the future. I have attached an example that illustrates the way I use the zero width character.

az305st1-q60

ronzulu commented 6 months ago

Hi @huetruong I would suggest you create a new discussion item, as this is not quite on topic.

I can put a comment in the code about this, please let us know what is the zero width character you are using.

longer term I think the solution will be something like: [FEAT] Support multiline questions with blank lines in both the card front and back

Cheers Ronny

ronzulu commented 6 months ago

Hello, I am currently facing an issue where I cannot display the review cards correctly. Since I am using a Mac Sonoma version 14.4.1, I am not quite sure how to locate the MD file you mentioned. If possible, could you please instruct me on how to proceed? Thank you very much. Sincerely Scicily

Hi @Scicily

Sorry, I'm not a Mac person - don't know where Obsidian. As an idea, click on the "vault" icon. On a PC it looks like: image

On the left hand side it shows the location on the vault in the file system, perhaps on your Mac it would give you a clue: image

Also, when you say "cannot display the review cards correctly" is the card:

  1. Missing, or
  2. Present and does display, but displays incorrectly

If the card does display, but incorrectly, then please open a new issue, as this issue is for cards that have gone missing after the recent release.

Cheers Ronny

huetruong commented 6 months ago

Hi @huetruong I would suggest you create a new discussion item, as this is not quite on topic.

I can put a comment in the code about this, please let us know what is the zero width character you are using.

longer term I think the solution will be something like: [FEAT] Support multiline questions with blank lines in both the card front and back

Cheers Ronny

I would definitely love to have that in the long term. Here is what I am using below as a work around.

https://www.groovypost.com/howto/type-zero-width-space/

ronzulu commented 6 months ago

Hi all

Beta release is now available. I've tested with most (if not all) of the files posted above and seems ok.

There is a file called main.js and style.css in this zip file main_915C.zip

You will need to copy them to the obsidian plug-in folder, e.g. D:\Obsidian\.obsidian\plugins\obsidian-spaced-repetition

Then reload the plug-in, or restart obsidian.

Any feedback appreciated.

Ronny

Scicily commented 6 months ago

Thank you for your assistance. In the meantime, I will research the data storage locations in MacOS and then apply the information you provided. (I am a new user of MacOS, still figuring out the logic of using a Mac.) Thank you. Sincerely, Scicily

Ronny Zulaikha @.***> 於 2024年4月3日 週三 上午7:29寫道:

Hi all

Beta release is now available. I've tested with most (if not all) of the files posted above and seems ok.

There is a file called main.js in this zip file main_915B.zip https://github.com/st3v3nmw/obsidian-spaced-repetition/files/14844589/main_915B.zip

You will need to copy that to the obsidian plug-in folder, e.g. D:\Obsidian.obsidian\plugins\obsidian-spaced-repetition

Then reload the plug-in, or restart obsidian.

Any feedback appreciated.

Ronny

— Reply to this email directly, view it on GitHub https://github.com/st3v3nmw/obsidian-spaced-repetition/issues/915#issuecomment-2033277592, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASYRUC37LPVGQGFBOSZRGCLY3NEMZAVCNFSM6AAAAABFDVKFVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZTGI3TONJZGI . You are receiving this because you were mentioned.Message ID: @.***>

Garg0yle commented 6 months ago

Hi all

Beta release is now available. I've tested with most (if not all) of the files posted above and seems ok.

There is a file called main.js and style.css in this zip file main_915C.zip

You will need to copy them to the obsidian plug-in folder, e.g. D:\Obsidian\.obsidian\plugins\obsidian-spaced-repetition

Then reload the plug-in, or restart obsidian.

Any feedback appreciated.

Ronny

Hi Ronny, this fixed the issue for me! Thanks so much for the work here.

huetruong commented 6 months ago

Hi all

Beta release is now available. I've tested with most (if not all) of the files posted above and seems ok.

There is a file called main.js and style.css in this zip file main_915C.zip

You will need to copy them to the obsidian plug-in folder, e.g. D:\Obsidian\.obsidian\plugins\obsidian-spaced-repetition

Then reload the plug-in, or restart obsidian.

Any feedback appreciated.

Ronny

I can confirm my issue is fixed.

Scicily commented 6 months ago

Thanks, I'll check it out!

Hue Truong @.***> 於 2024年4月6日 週六 上午8:12寫道:

Hi all

Beta release is now available. I've tested with most (if not all) of the files posted above and seems ok.

There is a file called main.js and style.css in this zip file main_915C.zip https://github.com/st3v3nmw/obsidian-spaced-repetition/files/14878031/main_915C.zip

You will need to copy them to the obsidian plug-in folder, e.g. D:\Obsidian.obsidian\plugins\obsidian-spaced-repetition

Then reload the plug-in, or restart obsidian.

Any feedback appreciated.

Ronny

I can confirm my issue is fixed.

— Reply to this email directly, view it on GitHub https://github.com/st3v3nmw/obsidian-spaced-repetition/issues/915#issuecomment-2040805236, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASYRUC5M34LFAHID56MVDMLY344WBAVCNFSM6AAAAABFDVKFVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQHAYDKMRTGY . You are receiving this because you were mentioned.Message ID: @.***>

ronzulu commented 6 months ago

Fixed in release 1.12.4, closing this now.

Scicily commented 5 months ago

Repaired and fully functional. Thank you very much.

Ronny Zulaikha @.***> 於 2024年4月23日 週二 下午8:14寫道:

Fixed in release 1.12.4, closing this now.

— Reply to this email directly, view it on GitHub https://github.com/st3v3nmw/obsidian-spaced-repetition/issues/915#issuecomment-2072144531, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASYRUC52P3ZVZ6RCQ7TUFJ3Y6ZGEFAVCNFSM6AAAAABFDVKFVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZSGE2DINJTGE . You are receiving this because you were mentioned.Message ID: @.***>