st4lk / django-rest-social-auth

OAuth signin with django rest framework
MIT License
519 stars 122 forks source link

Django 4 support #153

Closed alex-pobeditel-2004 closed 1 year ago

alex-pobeditel-2004 commented 2 years ago

Hello! Django 4.0 is out but this project pins Django version to <4.0 and prevents upgrade.

I tried to run make test locally to check if it will work "as is" but I keep getting errors during pip install phase - like these:
ERROR: Could not install packages due to an EnvironmentError: [Errno 13] Permission denied: '//django_rest_social_auth/venv/lib/python3.7/site-packages/typing_extensions.py' I don't know if these errors are caused by this strange // in the beginning of the path or by some environment mismatch (I tried on Arch Linux, Docker 20.10.12) and I failed to make it work.

Maybe you can check if it works with 4.0? social-core and social-app-django work with Python 3.10 / Django 4.0 so I think there are chances that your package is already compatible too.

alex-pobeditel-2004 commented 2 years ago

I managed to run tests with WSL and at least one problem showed up: existing bugfix in django-rest-knox needs to be released (https://github.com/James1345/django-rest-knox/issues/260) but the repository seems to be not maintained anymore.
So update to Django 4.0 (needs Python 3.8+) is impossible at the moment :(

But tests on Python 3.10 are passed so Python 3.10 can be added to test matrix

JulesVR commented 2 years ago

Hi @st4lk Would it be possible to create a release for django 4.0? django-rest-knox has been updated. Thanks Edit: django-rest-knox has not been updated yet, my apologies.

alex-pobeditel-2004 commented 2 years ago

@JulesVR knox with bugfix is still not released

JulesVR commented 2 years ago

@JulesVR knox with bugfix is still not released

Sorry, mislooked. Thanks.

alex-pobeditel-2004 commented 2 years ago

And hooray - knox bugfix was just released :)
https://github.com/James1345/django-rest-knox/releases/tag/4.2.0
@st4lk can you please try to create release for Python 3.10 / Django 4.0 now?

spapanik commented 2 years ago

Are there any updates on that?

sevdog commented 2 years ago

Is there an ETA for when this project will be compatible with Django 4.0?

tuergeist commented 2 years ago

@KOliver94 do you mind releasing your "next" branch as "rest-social-auth-ng"? It seems that this project went into deep sleep. Otherwise I'd take you changes to make a release.

KOliver94 commented 2 years ago

@tuergeist go for it, thanks! 🙂

sevdog commented 1 year ago

@st4lk are you going to provide any update to this project?

st4lk commented 1 year ago

Available in pypi v8.0.0

alex-pobeditel-2004 commented 1 year ago

@st4lk Thank you very much!