search

st4lk / django-rest-social-auth

OAuth signin with django rest framework
MIT License
521 stars 122 forks source link

Django 1.11 support? #47

Closed half0wl closed 6 years ago

half0wl commented 7 years ago

Are there any side effects to using this in Django 1.11 by updating the dependencies (social-auth-core==1.2.0 and social-auth-app-django==1.1.0)? As far as I can tell, the only error in Django 1.11 is due to python-social-auth/social-app-django#24, which is fixed by the latest releases of social-auth-core and social-app-django.

Related commit: b02f99f89321ea8f1f05468591d4f157d982ad49

oleksii-sl commented 7 years ago

seems to work fine on django 1.11, I've pulled 1.1.0 tag version of lib and updated tox file in order to test with latest django social-auth-core and social-auth-app-django. test were ok

tobias47n9e commented 7 years ago

Related PR: https://github.com/st4lk/django-rest-social-auth/pull/54

st4lk commented 6 years ago

The lib should support Django 1.11. If there are any errors regarding this, please reopen.