search

st4lk / django-rest-social-auth

OAuth signin with django rest framework
MIT License
521 stars 122 forks source link

Knox 4.0 update #93

Closed bernie-haxx closed 4 years ago

bernie-haxx commented 5 years ago

The token variable was creating a tuple consisting of the token and instance variable based on the knox 4.0 update. I can take my time in creating a whole token and expiry generation for the knox system if you let me.

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.3%) to 91.973% when pulling 8f90a1252489a691c35786324a4c3ed75a824d76 on Benard18:master into 6ba9a67659e8c981ddfa75e7e51e80a842183285 on st4lk:master.

st4lk commented 4 years ago

Fixed by https://github.com/st4lk/django-rest-social-auth/pull/112

I don't think we need to pass knox_settings.TOKEN_TTL here since it is the default value:

https://github.com/James1345/django-rest-knox/blob/4.1.0/knox/models.py#L12

class AuthTokenManager(models.Manager):
    def create(self, user, expiry=knox_settings.TOKEN_TTL)
        ...
bernie-haxx commented 4 years ago

Ooh sure.....saw the fix too.