search

st4lk / django-solid-i18n-urls

[DEPRECATED] Use default language for urls without language prefix.
http://www.lexev.org/en/
Other
112 stars 29 forks source link

Deprecation of prefix argument. #8

Closed julianwachholz closed 9 years ago

julianwachholz commented 9 years ago

The prefix argument to pattern() functions will be deprecated, see https://docs.djangoproject.com/en/dev/ref/urls/#django.conf.urls.patterns for info.

Since i18n_patterns rely on more than just the prefix, the argument should be made optional. E.g. if first argument is a URL instance just add it to the list and carry on.

st4lk commented 9 years ago

Julian, thanks for reporting! According to https://docs.djangoproject.com/en/dev/ref/urls/#django.conf.urls.patterns, not just prefix, but entire patterns() function will be deprecated.

But, according to i18n docs i18n_patterns() function remains, but prefix argument to i18n_patterns() will be deprecated since django v1.8 and in django v2.0 will be suppressed.

So, to be able to support future and previous django versions, you suggest to make prefix argument to solid_i18n_patterns() optional.

Am i right?

st4lk commented 9 years ago

Merged, now in v1.0.0. Thanks for contributing!